netdev - Re: [net-next PATCH v5 3/4] net: dsa: Add Airoha AN8855 5-Port Gigabit DSA Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6737d6ee.050a0220.34072b.91c7@mx.google.com>
Date: Sat, 16 Nov 2024 00:19:06 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	upstream@...oha.com
Subject: Re: [net-next PATCH v5 3/4] net: dsa: Add Airoha AN8855 5-Port
 Gigabit DSA Switch driver

On Fri, Nov 15, 2024 at 03:15:53PM -0800, Jakub Kicinski wrote:
> On Sat, 16 Nov 2024 00:03:55 +0100 Christian Marangi wrote:
> > > > Ok I will search for this but it does sounds like something new and not
> > > > used by other DSA driver, any hint on where to look for examples?  
> > > 
> > > It's relatively recent but I think the ops are plumbed thru to DSA.
> > > Take a look at all the *_stats members of struct dsa_switch_ops, most
> > > of them take a fixed format struct to fill in and the struct has some
> > > extra kdoc on which field is what.  
> > 
> > Thanks for the follow-up, they are the get_stats64 I assume, quite
> > different to the ethtools one as we need a poll logic. Ok I will check
> > what to drop and rework it.
> 
> https://elixir.bootlin.com/linux/v6.12-rc1/source/include/net/dsa.h#L915-L927
> 
> am I looking in the wrong place?

Yep should be those.

-- 
	Ansuel