netdev - Re: [PATCH RFC net 0/2] Fix race between datagram socket address change and rehash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zza5gypLK6jWDWov@zatzit>
Date: Fri, 15 Nov 2024 14:01:23 +1100
From: David Gibson <david@...son.dropbear.id.au>
To: Stefano Brivio <sbrivio@...hat.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Mike Manning <mmanning@...tta.att-mail.com>,
	Ed Santiago <santiago@...hat.com>,
	Paul Holzinger <pholzing@...hat.com>
Subject: Re: [PATCH RFC net 0/2] Fix race between datagram socket address
 change and rehash

On Thu, Nov 14, 2024 at 10:54:12PM +0100, Stefano Brivio wrote:
> Patch 2/2 fixes a race condition in the lookup of datagram sockets
> between address change (triggered by connect()) and rehashing.
> 
> Patch 1/2 is a small optimisation to simplify 2/2.

These both LGTM, but I don't know the code in question well enough to
claim to have done a full review.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)