netdev - Re: [PATCH net-next v0 1/1] net: mv643xx_eth: disable IP tx checksum with jumbo frames for Armada 310

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241114192459.75e5b4d9@kernel.org>
Date: Thu, 14 Nov 2024 19:24:59 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Qingtao Cao <qingtao.cao.au@...il.com>
Cc: Qingtao Cao <qingtao.cao@...i.com>, Sebastian Hesselbarth
 <sebastian.hesselbarth@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v0 1/1] net: mv643xx_eth: disable IP tx
 checksum with jumbo frames for Armada 310

On Wed, 13 Nov 2024 21:00:40 +1000 Qingtao Cao wrote:
> The Ethernet controller found in Armada 310 doesn't support TCP/IP checksum
> with frame sizes larger than its TX checksum offload limit
> 
> Disable the features NETIF_F_IP_CSUM and NETIF_F_TSO when the MTU is set to
> a value larger than this limit, to prevent the software TSO generating GSO
> packets that are not suitable to offload to the Ethernet controller, which
> would be calculated by the IP stack instead.

Did you consider disabling it per packet using .ndo_features_check ?