netdev - Re: [PATCH net-next v4] net: dlink: add support for reporting stats via `ethtool -S`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241115164852.0d46d6de@kernel.org>
Date: Fri, 15 Nov 2024 16:48:52 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Moon Yeounsu <yyyynoom@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4] net: dlink: add support for reporting stats
 via `ethtool -S`

On Fri, 15 Nov 2024 00:19:48 +0900 Moon Yeounsu wrote:
> -	dev->stats.rx_packets += dr32(FramesRcvOk);
> -	dev->stats.tx_packets += dr32(FramesXmtOk);
> -	dev->stats.rx_bytes += dr32(OctetRcvOk);
> -	dev->stats.tx_bytes += dr32(OctetXmtOk);
> -
> -	dev->stats.multicast = dr32(McstFramesRcvdOk);
> -	dev->stats.collisions += dr32(SingleColFrames)
> -			     +  dr32(MultiColFrames);
> -
> -	/* detailed tx errors */
> -	stat_reg = dr16(FramesAbortXSColls);
> -	dev->stats.tx_aborted_errors += stat_reg;
> -	dev->stats.tx_errors += stat_reg;
> -
> -	stat_reg = dr16(CarrierSenseErrors);
> -	dev->stats.tx_carrier_errors += stat_reg;
> -	dev->stats.tx_errors += stat_reg;

Maybe I'm lost in the macros again, but I dont see where you are
updating dev->stats now. 

Do basic stats still work?

ip -s -s link show
-- 
pw-bot: cr