| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <cbca5f57-bc29-4d3e-a009-8ac3f5d38600@csgroup.eu>
Date: Sat, 16 Nov 2024 11:16:09 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>,
Pablo Neira Ayuso <pablo@...filter.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Simon Horman <horms@...nel.org>, Julia Lawall <Julia.Lawall@...ia.fr>,
Nicolas Palix <nicolas.palix@...g.fr>, Daniel Mack <daniel@...que.org>,
Haojian Zhuang <haojian.zhuang@...il.com>,
Robert Jarzmik <robert.jarzmik@...e.fr>, Russell King
<linux@...linux.org.uk>, Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
<agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>,
Sven Schnelle <svens@...ux.ibm.com>, Ofir Bitton <obitton@...ana.ai>,
Oded Gabbay <ogabbay@...nel.org>, Lucas De Marchi
<lucas.demarchi@...el.com>,
Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Jeroen de Borst <jeroendb@...gle.com>,
Praveen Kaligineedi <pkaligineedi@...gle.com>,
Shailend Chand <shailend@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>,
James Smart <james.smart@...adcom.com>,
Dick Kennedy <dick.kennedy@...adcom.com>,
"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Roger Pau Monné <roger.pau@...rix.com>,
Jens Axboe <axboe@...nel.dk>, Kalle Valo <kvalo@...nel.org>,
Jeff Johnson <jjohnson@...nel.org>, Catalin Marinas
<catalin.marinas@....com>, Andrew Morton <akpm@...ux-foundation.org>,
Jack Wang <jinpu.wang@...ud.ionos.com>, Marcel Holtmann
<marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Florian Fainelli <florian.fainelli@...adcom.com>, Ray Jui
<rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>, Xiubo Li <xiubli@...hat.com>,
Ilya Dryomov <idryomov@...il.com>, Josh Poimboeuf <jpoimboe@...nel.org>,
Jiri Kosina <jikos@...nel.org>, Miroslav Benes <mbenes@...e.cz>,
Petr Mladek <pmladek@...e.com>, Joe Lawrence <joe.lawrence@...hat.com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Lucas Stach <l.stach@...gutronix.de>,
Russell King <linux+etnaviv@...linux.org.uk>,
Christian Gmeiner <christian.gmeiner@...il.com>,
Louis Peens <louis.peens@...igine.com>, Michael Ellerman
<mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
Naveen N Rao <naveen@...nel.org>, Madhavan Srinivasan <maddy@...ux.ibm.com>
Cc: netfilter-devel@...r.kernel.org, coreteam@...filter.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org, cocci@...ia.fr,
linux-arm-kernel@...ts.infradead.org, linux-s390@...r.kernel.org,
dri-devel@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
linux-scsi@...r.kernel.org, xen-devel@...ts.xenproject.org,
linux-block@...r.kernel.org, linux-wireless@...r.kernel.org,
ath11k@...ts.infradead.org, linux-mm@...ck.org,
linux-bluetooth@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-rpi-kernel@...ts.infradead.org, ceph-devel@...r.kernel.org,
live-patching@...r.kernel.org, linux-sound@...r.kernel.org,
etnaviv@...ts.freedesktop.org, oss-drivers@...igine.com,
linuxppc-dev@...ts.ozlabs.org, Anna-Maria Behnsen <anna-maria@...utronix.de>
Subject: Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit :
> [Vous ne recevez pas souvent de courriers de eahariha@...ux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> This is a series that follows up on my previous series to introduce
> secs_to_jiffies() and convert a few initial users.[1] In the review for
> that series, Anna-Maria requested converting other users with
> Coccinelle. This is part 1 that converts users of msecs_to_jiffies()
> that use the multiply pattern of either of:
> - msecs_to_jiffies(N*1000), or
> - msecs_to_jiffies(N*MSEC_PER_SEC)
You should provide a reference to the accepted commit that adds
secs_to_jiffies:
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()")
>
> The entire conversion is made with Coccinelle in the script added in
> patch 2. Some changes suggested by Coccinelle have been deferred to
> later parts that will address other possible variant patterns.
>
> CC: Anna-Maria Behnsen <anna-maria@...utronix.de>
> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
>
> [1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20241030-open-coded-timeouts-v3-0-9ba123facf88%40linux.microsoft.com%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C121622b159564a010cac08dd05bc32da%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638673028056187739%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=oW04hGIpfjRo8qcX0GaGdHE1xiApgoOtgAuWQXFgWR4%3D&reserved=0
> [2] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F8734kngfni.fsf%40somnus%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C121622b159564a010cac08dd05bc32da%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638673028056211741%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=UDn89U6oUNFiRj3K5fvNEIuiwmwEGfJ2XhPn43z8%2BhA%3D&reserved=0
>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fr%2F20241115-converge-secs-to-jiffies-v1-0-19aadc34941b%40linux.microsoft.com&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C121622b159564a010cac08dd05bc32da%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638673028056225723%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=reWzZOiSyn%2FA5qxcXAoUqNGedJ1K%2FM%2BuCgEKwXusuU8%3D&reserved=0
>
> ---
> Easwar Hariharan (21):
> netfilter: conntrack: Cleanup timeout definitions
> coccinelle: misc: Add secs_to_jiffies script
> arm: pxa: Convert timeouts to use secs_to_jiffies()
> s390: kernel: Convert timeouts to use secs_to_jiffies()
> powerpc/papr_scm: Convert timeouts to secs_to_jiffies()
> mm: kmemleak: Convert timeouts to secs_to_jiffies()
> accel/habanalabs: Convert timeouts to secs_to_jiffies()
> drm/xe: Convert timeout to secs_to_jiffies()
> drm/etnaviv: Convert timeouts to secs_to_jiffies()
> scsi: lpfc: Convert timeouts to secs_to_jiffies()
> scsi: arcmsr: Convert timeouts to secs_to_jiffies()
> scsi: pm8001: Convert timeouts to secs_to_jiffies()
> xen/blkback: Convert timeouts to secs_to_jiffies()
> gve: Convert timeouts to secs_to_jiffies()
> wifi: ath11k: Convert timeouts to secs_to_jiffies()
> Bluetooth: MGMT: Convert timeouts to secs_to_jiffies()
> staging: vc04_services: Convert timeouts to secs_to_jiffies()
> ceph: Convert timeouts to secs_to_jiffies()
> livepatch: Convert timeouts to secs_to_jiffies()
> ALSA: line6: Convert timeouts to secs_to_jiffies()
> nfp: Convert timeouts to secs_to_jiffies()
>
> arch/arm/mach-pxa/sharpsl_pm.c | 6 +++---
> arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
> arch/s390/kernel/lgr.c | 3 ++-
> arch/s390/kernel/time.c | 4 ++--
> arch/s390/kernel/topology.c | 2 +-
> drivers/accel/habanalabs/common/device.c | 2 +-
> drivers/accel/habanalabs/common/habanalabs_drv.c | 3 +--
> drivers/block/xen-blkback/blkback.c | 2 +-
> drivers/gpu/drm/etnaviv/etnaviv_cmdbuf.c | 2 +-
> drivers/gpu/drm/xe/xe_device.c | 2 +-
> drivers/net/ethernet/google/gve/gve_tx_dqo.c | 6 ++----
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
> drivers/net/wireless/ath/ath11k/debugfs.c | 2 +-
> drivers/scsi/arcmsr/arcmsr_hba.c | 2 +-
> drivers/scsi/lpfc/lpfc_init.c | 18 +++++++++---------
> drivers/scsi/lpfc/lpfc_nportdisc.c | 8 ++++----
> drivers/scsi/lpfc/lpfc_nvme.c | 2 +-
> drivers/scsi/lpfc/lpfc_sli.c | 4 ++--
> drivers/scsi/lpfc/lpfc_vmid.c | 2 +-
> drivers/scsi/pm8001/pm8001_init.c | 2 +-
> .../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
> fs/ceph/quota.c | 2 +-
> mm/kmemleak.c | 4 ++--
> net/bluetooth/mgmt.c | 2 +-
> net/netfilter/nf_conntrack_proto_sctp.c | 21 ++++++++-------------
> samples/livepatch/livepatch-callbacks-busymod.c | 2 +-
> samples/livepatch/livepatch-shadow-fix1.c | 2 +-
> samples/livepatch/livepatch-shadow-mod.c | 10 +++++-----
> scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++
> sound/usb/line6/toneport.c | 2 +-
> 30 files changed, 79 insertions(+), 65 deletions(-)
> ---
> base-commit: 2d5404caa8c7bb5c4e0435f94b28834ae5456623
> change-id: 20241112-converge-secs-to-jiffies-d99d1016bd11
>
> Best regards,
> --
> Easwar Hariharan <eahariha@...ux.microsoft.com>
>
Powered by blists - more mailing lists