Message-Id: <272B86FC-5CC9-4A3A-ACE0-F268E4E61C3D@inria.fr>
Date: Sat, 16 Nov 2024 06:24:20 -0500
From: Julia Lawall <Julia.Lawall@...ia.fr>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Christophe Leroy <christophe.leroy@...roup.eu>,
 Easwar Hariharan <eahariha@...ux.microsoft.com>,
 Pablo Neira Ayuso <pablo@...filter.org>,
 Jozsef Kadlecsik <kadlec@...filter.org>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Nicolas Palix <nicolas.palix@...g.fr>, Daniel Mack <daniel@...que.org>,
 Haojian Zhuang <haojian.zhuang@...il.com>,
 Robert Jarzmik <robert.jarzmik@...e.fr>,
 Russell King <linux@...linux.org.uk>, Heiko Carstens <hca@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>, Ofir Bitton <obitton@...ana.ai>,
 Oded Gabbay <ogabbay@...nel.org>,
 Lucas De Marchi <lucas.demarchi@...el.com>,
 Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Jeroen de Borst <jeroendb@...gle.com>,
 Praveen Kaligineedi <pkaligineedi@...gle.com>,
 Shailend Chand <shailend@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 James Smart <james.smart@...adcom.com>,
 Dick Kennedy <dick.kennedy@...adcom.com>,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Roger Pau Monné <roger.pau@...rix.com>,
 Jens Axboe <axboe@...nel.dk>, Kalle Valo <kvalo@...nel.org>,
 Jeff Johnson <jjohnson@...nel.org>,
 Catalin Marinas <catalin.marinas@....com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Jack Wang <jinpu.wang@...ud.ionos.com>,
 Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
 Xiubo Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>,
 Josh Poimboeuf <jpoimboe@...nel.org>, Jiri Kosina <jikos@...nel.org>,
 Miroslav Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>,
 Joe Lawrence <joe.lawrence@...hat.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Lucas Stach <l.stach@...gutronix.de>,
 Russell King <linux+etnaviv@...linux.org.uk>,
 Christian Gmeiner <christian.gmeiner@...il.com>,
 Louis Peens <louis.peens@...igine.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>, netfilter-devel@...r.kernel.org,
 coreteam@...filter.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 cocci@...ia.fr, linux-arm-kernel@...ts.infradead.org,
 linux-s390@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 intel-xe@...ts.freedesktop.org, linux-scsi@...r.kernel.org,
 xen-devel@...ts.xenproject.org, linux-block@...r.kernel.org,
 linux-wireless@...r.kernel.org, ath11k@...ts.infradead.org,
 linux-mm@...ck.org, linux-bluetooth@...r.kernel.org,
 linux-staging@...ts.linux.dev, linux-rpi-kernel@...ts.infradead.org,
 ceph-devel@...r.kernel.org, live-patching@...r.kernel.org,
 linux-sound@...r.kernel.org, etnaviv@...ts.freedesktop.org,
 oss-drivers@...igine.com, linuxppc-dev@...ts.ozlabs.org,
 Anna-Maria Behnsen <anna-maria@...utronix.de>
Subject: Re: [PATCH v2 05/21] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()


Sent from my iPhone

> On 16 Nov 2024, at 05:40, Dan Carpenter <dan.carpenter@...aro.org> wrote:
> 
> On Sat, Nov 16, 2024 at 11:06:55AM +0100, Christophe Leroy wrote:
>>> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
>>> index 9e297f88adc5d97d4dc7b267b0bfebd58e5cf193..9e8086ec66e0f0e555ac27933854c06cfcf91a04 100644
>>> --- a/arch/powerpc/platforms/pseries/papr_scm.c
>>> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
>>> @@ -543,7 +543,7 @@ static int drc_pmem_query_health(struct papr_scm_priv *p)
>>> 
>>>         /* Jiffies offset for which the health data is assumed to be same */
>>>         cache_timeout = p->lasthealth_jiffies +
>>> -               msecs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL * 1000);
>>> +               secs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL);
>> 
>> Wouldn't it now fit on a single line ?
>> 
> 
> Some maintainers still prefer to put a line break at 80 characters.  

Coccinelle tries for 80 chars. It may have a command line option to specify something else.

Julia

> It's kind
> of a nightmare for an automated script like this to figure out everyone's
> preferences.  In this particular
> file, there are some lines which go over 80
> characters so sure.  Earlier in the patchset one of these introduced a line
> break that wasn't there before so I think maybe Coccinelle is applying the 80
> character line break rule?
> 
> There are sometimes where the 80 character rule really hurts readability, but
> here it doesn't make any difference.
> 
> regards,
> dan carpenter
> 

Powered by blists - more mailing lists