netdev - RE: [EXTERNAL] Re: [PATCH net v4 1/7] octeon_ep: Add checks to fix double free crashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH0PR18MB473449C495237697452E777DC7252@PH0PR18MB4734.namprd18.prod.outlook.com>
Date: Sat, 16 Nov 2024 17:25:29 +0000
From: Shinas Rasheed <srasheed@...vell.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Haseeb Gani <hgani@...vell.com>, Sathesh B Edara <sedara@...vell.com>,
        Vimlesh Kumar <vimleshk@...vell.com>,
        "thaller@...hat.com"
	<thaller@...hat.com>,
        "wizhao@...hat.com" <wizhao@...hat.com>,
        "kheib@...hat.com" <kheib@...hat.com>,
        "egallen@...hat.com"
	<egallen@...hat.com>,
        "konguyen@...hat.com" <konguyen@...hat.com>,
        "horms@...nel.org" <horms@...nel.org>,
        Veerasenareddy Burru
	<vburru@...vell.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Abhijit Ayarekar
	<aayarekar@...vell.com>,
        Satananda Burla <sburla@...vell.com>
Subject: RE: [EXTERNAL] Re: [PATCH net v4 1/7] octeon_ep: Add checks to fix
 double free crashes

Hi Vadim,

> On 13/11/2024 11:13, Shinas Rasheed wrote:
> > From: Vimlesh Kumar <vimleshk@...vell.com>
> >
> > Add required checks to avoid double free. Crashes were
> > observed due to the same on reset scenarios, when reset
> > was tried multiple times, and the first reset had torn
> > down resources already.
> 
> I'm looking at the whole series and it feels like we have to deal
> with the root cause rather than add protective code left and right.
> 
> The driver may potentially have some locks missing which will cause
> missing resources, and to fix the root cause these locks have to be
> added. WDYT?

I will rework this patch series. I think some of the patchsets need not be present upstream
as they have come from some customer crashes which only occur in conjunction with other
proprietary modules and features present. I will rework this one to only include changes pertinent
to code upstream.

Thanks a lot for your comments