netdev - Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTUt9fuWy0BB3o35COr4ToDDtaAHB8AT-3sB+L-6cCyUgg@mail.gmail.com>
Date: Sun, 17 Nov 2024 21:31:31 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, 
	almasrymina@...gle.com, donald.hunter@...il.com, corbet@....net, 
	michael.chan@...adcom.com, andrew+netdev@...n.ch, hawk@...nel.org, 
	ilias.apalodimas@...aro.org, ast@...nel.org, daniel@...earbox.net, 
	john.fastabend@...il.com, dw@...idwei.uk, sdf@...ichev.me, 
	asml.silence@...il.com, brett.creeley@....com, linux-doc@...r.kernel.org, 
	netdev@...r.kernel.org, kory.maincent@...tlin.com, 
	maxime.chevallier@...tlin.com, danieller@...dia.com, hengqi@...ux.alibaba.com, 
	ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com, hkallweit1@...il.com, 
	ahmed.zaki@...el.com, rrameshbabu@...dia.com, idosch@...dia.com, 
	jiri@...nulli.us, bigeasy@...utronix.de, lorenzo@...nel.org, 
	jdamato@...tly.com, aleksander.lobakin@...el.com, kaiyuanz@...gle.com, 
	willemb@...gle.com, daniel.zahka@...il.com
Subject: Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh

On Sat, Nov 16, 2024 at 4:18 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sat, 16 Nov 2024 03:05:33 +0900 Taehee Yoo wrote:
> > > nit: s/_HEADER_DATA_SPLIT_/_HDS_/ ;)
> > >
> > > We can explain in the text that HDS stands for header data split.
> > > Let's not bloat the code with 40+ character names...
> >
> > I'm not familiar with the ynl, but I think there are some dependencies
> > between Documentation/netlink/spec/ethtool.yaml.
> > Because It seems to generate ethtool-user.c code automatically based
> > on ethtool.yaml spec. I think If we change this name to HDS, it need to
> > change ethtool spec form "header-data-split-thresh" to "hds-thresh" too.
> >
> > However, I agree with changing ethtool option name from
> > "header-data-split-thresh" to "hds-thresh". So, If I understand correctly,
> > what about changing ethtool option name from "header-data-split-thresh"
> > to "hds-thresh"?
>
> Correct. And yes, you'll need to change in both places the spec and the
> header. FWIW Stanislav is working on auto-generating the ethtool header
> from the YAML spec, hopefully that will avoid having to change both
> places long term.

Thanks! I will change both things.

Thanks a lot!
Taehee Yoo