netdev - Re: [PATCH v4 net-next 3/3] net: ena: Add PHC documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzlOPEyFxOjvPJd2@hoboy.vegasvil.org>
Date: Sat, 16 Nov 2024 18:00:28 -0800
From: Richard Cochran <richardcochran@...il.com>
To: David Arinzon <darinzon@...zon.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>,
	"Woodhouse, David" <dwmw@...zon.com>,
	"Machulsky, Zorik" <zorik@...zon.com>,
	"Matushevsky, Alexander" <matua@...zon.com>,
	Saeed Bshara <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>,
	"Liguori, Anthony" <aliguori@...zon.com>,
	"Bshara, Nafea" <nafea@...zon.com>,
	"Schmeilin, Evgeny" <evgenys@...zon.com>,
	"Belgazal, Netanel" <netanel@...zon.com>,
	"Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>,
	"Kiyanovski, Arthur" <akiyano@...zon.com>,
	"Dagan, Noam" <ndagan@...zon.com>,
	"Bernstein, Amit" <amitbern@...zon.com>,
	"Agroskin, Shay" <shayagr@...zon.com>,
	"Abboud, Osama" <osamaabb@...zon.com>,
	"Ostrovsky, Evgeny" <evostrov@...zon.com>,
	"Tabachnik, Ofir" <ofirt@...zon.com>,
	"Machnikowski, Maciek" <maciek@...hnikowski.net>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Gal Pressman <gal@...dia.com>
Subject: Re: [PATCH v4 net-next 3/3] net: ena: Add PHC documentation

On Sat, Nov 16, 2024 at 05:53:26PM -0800, Richard Cochran wrote:
> On Thu, Nov 14, 2024 at 11:59:30AM +0200, David Arinzon wrote:
> 
> > +**phc_skp**         Number of skipped get time attempts (during block period).
> > +**phc_err**         Number of failed get time attempts (entering into block state).
> 
> Just curious...  I understand that the HW can't support a very high
> rate of gettime calls and that the driver will throttle them.
> 
> But why did you feel the need to document the throttling behavior in
> such a overt way?  Are there user space programs out there calling
> gettime excessively?

Answering my own question (maybe)

I see that your PHC only supports gettime(), and so I guess you must
have some atypical system setup in mind.

I didn't see any comments in the cover letter or in the patch about
why the PHC isn't adjustable or how offering gettime() only is useful?

Thanks,
Richard