netdev - Re: [PATCH v6 3/3] vsock/test: verify socket options after setting them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <542cb6ed-8e2b-407e-9f9d-037144740b93@linux.ibm.com>
Date: Mon, 18 Nov 2024 09:54:04 -0600
From: Konstantin Shkolnyy <kshk@...ux.ibm.com>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: virtualization@...ts.linux.dev, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, mjrosato@...ux.ibm.com
Subject: Re: [PATCH v6 3/3] vsock/test: verify socket options after setting
 them

On 11/14/2024 04:28, Stefano Garzarella wrote:
> On Wed, Nov 13, 2024 at 08:35:57AM -0600, Konstantin Shkolnyy wrote:
[...]
>> diff --git a/tools/testing/vsock/msg_zerocopy_common.c b/tools/ 
>> testing/vsock/msg_zerocopy_common.c
>> index 5a4bdf7b5132..8622e5a0f8b7 100644
>> --- a/tools/testing/vsock/msg_zerocopy_common.c
>> +++ b/tools/testing/vsock/msg_zerocopy_common.c
>> @@ -14,16 +14,6 @@
>>
>> #include "msg_zerocopy_common.h"
>>
>> -void enable_so_zerocopy(int fd)
>> -{
>> -    int val = 1;
>> -
>> -    if (setsockopt(fd, SOL_SOCKET, SO_ZEROCOPY, &val, sizeof(val))) {
>> -        perror("setsockopt");
>> -        exit(EXIT_FAILURE);
>> -    }
>> -}
>> -
> 
> Since the new API has a different name (i.e.
> `enable_so_zerocopy_check()`), this `enable_so_zerocopy()` could stay
> here, anyway I don't want to be too picky, I'm totally fine with this
> change since it's now only used by vsock_perf ;-)
> 
> Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>
> 

Ok, let's keep it static then - it's simpler :-)