netdev - Re: [PATCH net-next] net: phy: qt2025: simplify Result<()> in probe return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7f483b0-31de-4098-9416-18dfd0944550@linuxfoundation.org>
Date: Mon, 18 Nov 2024 14:23:15 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Manas <manas18244@...td.ac.in>, Andrew Lunn <andrew@...n.ch>
Cc: FUJITA Tomonori <fujita.tomonori@...il.com>,
 Trevor Gross <tmgross@...ch.edu>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Anup Sharma <anupnewsmail@...il.com>, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH net-next] net: phy: qt2025: simplify Result<()> in probe
 return

On 11/18/24 07:28, Manas wrote:
> On 18.11.2024 15:15, Andrew Lunn wrote:
>> On Mon, Nov 18, 2024 at 06:39:34PM +0530, Manas via B4 Relay wrote:
>>> From: Manas <manas18244@...td.ac.in>
>>>
>>> probe returns a `Result<()>` type, which can be simplified as `Result`,
>>> due to default type parameters being unit `()` and `Error` types. This
>>> maintains a consistent usage of `Result` throughout codebase.
>>>
>>> Signed-off-by: Manas <manas18244@...td.ac.in>
>>
>> Miguel has already pointed out, this is probably not sufficient for a
>> signed-off-by: You need a real name here, in order to keep the lawyers happy.
>>
> Hi Andrew, I did clarify that "Manas" is my real name, (as in what the official
> documents have). It is not a pseudonym. I am unsure if I am missing something
> here.
> 

Using your full name in your Signed-off-by clearly identifies the author.
I would recommend going that route.

thanks,
-- Shuah