netdev - Re: [PATCH net] net: mdio-ipq4019: fix wrong NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5562cf54-d1bd-4235-b232-33f5cca40b85@quicinc.com>
Date: Mon, 18 Nov 2024 18:26:27 +0800
From: Jie Luo <quic_luoj@...cinc.com>
To: Rosen Penev <rosenp@...il.com>, <netdev@...r.kernel.org>
CC: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: mdio-ipq4019: fix wrong NULL check



On 11/18/2024 5:28 AM, Rosen Penev wrote:
> devm_ioremap_resource returns a PTR_ERR when it fails, not NULL. OTOH
> this is conditionally set to either a PTR_ERR or a valid pointer. Use
> !IS_ERR_OR_NULL to check if we can use this.
> 
> Fixes: 23a890d493 ("net: mdio: Add the reset function for IPQ MDIO driver")
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>   drivers/net/mdio/mdio-ipq4019.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mdio/mdio-ipq4019.c b/drivers/net/mdio/mdio-ipq4019.c
> index dd3ed2d6430b..859302b0d38c 100644
> --- a/drivers/net/mdio/mdio-ipq4019.c
> +++ b/drivers/net/mdio/mdio-ipq4019.c
> @@ -256,7 +256,7 @@ static int ipq_mdio_reset(struct mii_bus *bus)
>   	/* To indicate CMN_PLL that ethernet_ldo has been ready if platform resource 1
>   	 * is specified in the device tree.
>   	 */
> -	if (priv->eth_ldo_rdy) {
> +	if (!IS_ERR_OR_NULL(priv->eth_ldo_rdy)) {
>   		val = readl(priv->eth_ldo_rdy);
>   		val |= BIT(0);
>   		writel(val, priv->eth_ldo_rdy);

Reviewed-by: Luo Jie <quic_luoj@...cinc.com>

Thanks,
Jie