netdev - Re: [PATCH net-next v2] mm: page_frag: fix a compile error when kernel is not compiled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06940878-8a7c-441c-958b-7cd7e7408beb@redhat.com>
Date: Tue, 19 Nov 2024 12:40:58 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Yunsheng Lin <linyunsheng@...wei.com>, davem@...emloft.net,
 kuba@...nel.org
Cc: netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
 Alexander Duyck <alexanderduyck@...com>, Linux-MM <linux-mm@...ck.org>,
 Mark Brown <broonie@...nel.org>, Shuah Khan <shuah@...nel.org>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] mm: page_frag: fix a compile error when
 kernel is not compiled

On 11/19/24 04:30, Yunsheng Lin wrote:
> page_frag test module is an out of tree module, but built
> using KDIR as the main kernel tree, the mm test suite is
> just getting skipped if newly added page_frag test module
> fails to compile due to kernel not yet compiled.
> 
> Fix the above problem by ensuring both kernel is built first
> and a newer kernel which has page_frag_cache.h is used.
> 
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Alexander Duyck <alexanderduyck@...com>
> CC: Linux-MM <linux-mm@...ck.org>
> Fixes: 7fef0dec415c ("mm: page_frag: add a test module for page_frag")
> Fixes: 65941f10caf2 ("mm: move the page fragment allocator from page_alloc into its own file")
> Reported-by: Mark Brown <broonie@...nel.org>
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> Tested-by: Mark Brown <broonie@...nel.org>

I'm closing the net-next PR right now, and we must either apply this
patch even on short notice or reverting the blamed series.

As this fix should not cause any more conflict than the original series,
looks reasonable to me and has been tested by Mark, I'm going to apply it.

/P