netdev - Re: [PATCH net-next V3 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zzyq7BEoaJHk4uy8@nanopsycho.orion>
Date: Tue, 19 Nov 2024 16:12:44 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Carolina Jubran <cjubran@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Cosmin Ratiu <cratiu@...dia.com>, donald.hunter@...il.com
Subject: Re: [PATCH net-next V3 3/8] devlink: Extend devlink rate API with
 traffic classes bandwidth management

Tue, Nov 19, 2024 at 03:51:18PM CET, kuba@...nel.org wrote:
>On Tue, 19 Nov 2024 15:46:28 +0100 Jiri Pirko wrote:
>> >> Not sure. Perhaps Jakub/Donald would know. Ccing.  
>> >
>> >I haven't read full context, but all "nested" arrays are discouraged.
>> >Use:
>> >	multi-attr: true
>> >and repeat the entries without wrapping them into another attr.  
>> 
>> But we need to use the array index. It looks a bit odd to me to depent
>> on the index in multi-attr in general. It is not guaranteed other
>> atrributes don't get in the middle. Ordering should be maintained, that
>> is ok.
>> 
>> How about to have a nest that contain just one multi-attr attribute?
>
>You can make the entry a nest and put the index inside, if it is 
>significant.

Okay, sounds fine to me.