netdev - Re: [PATCH net-next v3] net/smc: Optimize the search method of reused buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241118182141.20471ab8@kernel.org>
Date: Mon, 18 Nov 2024 18:21:41 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: liqiang <liqiang64@...wei.com>
Cc: <wenjia@...ux.ibm.com>, <jaka@...ux.ibm.com>,
 <alibuda@...ux.alibaba.com>, <tonylu@...ux.alibaba.com>,
 <guwen@...ux.alibaba.com>, <dust.li@...ux.alibaba.com>,
 <linux-s390@...r.kernel.org>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <luanjianhai@...wei.com>,
 <zhangxuzhou4@...wei.com>, <dengguangxing@...wei.com>,
 <gaochao24@...wei.com>
Subject: Re: [PATCH net-next v3] net/smc: Optimize the search method of
 reused buf_desc

On Tue, 12 Nov 2024 17:22:16 +0800 liqiang wrote:
> We create a lock-less link list for the currently
> idle reusable smc_buf_desc.
> 
> When the 'used' filed mark to 0, it is added to
> the lock-less linked list.
> 
> When a new connection is established, a suitable
> element is obtained directly, which eliminates the
> need for traversal and search, and does not require
> locking resource.
> 
> Through my testing, this patch can significantly improve 
> the link establishment speed of SMC, especially in the 
> multi-threaded short connection benchmark.
> 
> I tested the time-consuming comparison of this function
> under multiple connections based on redis-benchmark
> (test in smc loopback-ism mode):
> 
> The function 'smc_buf_get_slot' takes less time when a
> new SMC link is established:
> 1. 5us->100ns (when there are 200 active links);
> 2. 30us->100ns (when there are 1000 active links).

We're closing net-next and didn't get any review tags on this patch,
either from IBM or Alibaba folks. Please try again after the merge
window (after Dec 2nd, once v6.13-rc1 is tagged).
-- 
pw-bot: defer