netdev - Re: [PATCH net-next v1 1/1] net: mv643xx_eth: disable IP tx checksum with jumbo frames for Armada 310

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241118191111.7286dc2c@kernel.org>
Date: Mon, 18 Nov 2024 19:11:11 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Qingtao Cao <qingtao.cao.au@...il.com>
Cc: Qingtao Cao <qingtao.cao@...i.com>, Sebastian Hesselbarth
 <sebastian.hesselbarth@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v1 1/1] net: mv643xx_eth: disable IP tx
 checksum with jumbo frames for Armada 310

On Mon, 18 Nov 2024 10:45:09 +1000 Qingtao Cao wrote:
> The Ethernet controller found in Armada 310 doesn't support TCP/IP checksum
> with frame sizes larger than its TX checksum offload limit
> 
> When the path MTU is larger than this limit, the skb_warn_bad_offload will
> throw out a warning oops
> 
> Disable the TX checksum offload (NETIF_F_IP_CSUM) when the MTU is set to a
> value larger than this limit, the NETIF_F_TSO will automatically be disabled
> as a result and the IP stack will calculate jumbo frames' checksum instead.

I thought I suggested ndo_features_check, why are you using
fix_features?
-- 
pw-bot: cr