netdev - Re: [PATCH net 1/1] net: stmmac: set initial EEE policy configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b768de9-5404-4efb-be17-86dcef21dbd9@intel.com>
Date: Wed, 20 Nov 2024 11:48:22 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Choong Yong Liang <yong.liang.choong@...ux.intel.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, Russell King <linux@...linux.org.uk>, "David S .
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexandre
 Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>,
	"Maxime Coquelin" <mcoquelin.stm32@...il.com>, Oleksij Rempel
	<o.rempel@...gutronix.de>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net 1/1] net: stmmac: set initial EEE policy configuration



On 11/20/2024 12:38 AM, Choong Yong Liang wrote:
> Set the initial eee_cfg values to have 'ethtool --show-eee ' display
> the initial EEE configuration.
> 
> Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 7bf275f127c9..766213ee82c1 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1205,6 +1205,9 @@ static int stmmac_init_phy(struct net_device *dev)
>  			return -ENODEV;
>  		}
>  
> +		if (priv->dma_cap.eee)
> +			phy_support_eee(phydev);
> +

Ok, so priv->dma_cap.eee is true, then this device supports EEE, and we
call phy_support_eee which will initialize the values indicating that we
support the feature for ethtool.

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  		ret = phylink_connect_phy(priv->phylink, phydev);
>  	} else {
>  		fwnode_handle_put(phy_fwnode);