netdev - Re: [PATCH] net: phylink: Separating two unrelated definitions for improving code readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zz2id5-T-2-_jj4Q@shell.armlinux.org.uk>
Date: Wed, 20 Nov 2024 08:48:55 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Cong Yi <yicong.srfy@...mail.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Cong Yi <yicong@...inos.cn>
Subject: Re: [PATCH] net: phylink: Separating two unrelated definitions for
 improving code readability

On Wed, Nov 20, 2024 at 02:27:53PM +0800, Cong Yi wrote:
> From: Cong Yi <yicong@...inos.cn>
> 
> After the support of PCS state machine, phylink and pcs two
> unrelated state enum definitions are put together, which brings
> some confusion to code reading.

Hmm, so the definitions being prefixed with "PCS_STATE_" and the
variable being called "pcs_state" isn't enough?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!