netdev - Re: [PATCH] wifi: wilc1000: Rework bus locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c4d655d5-93d3-41dd-a958-c9305ab82fcd@denx.de>
Date: Thu, 21 Nov 2024 02:39:40 +0100
From: Marek Vasut <marex@...x.de>
To: Ajay.Kathat@...rochip.com, alexis.lothore@...tlin.com,
 linux-wireless@...r.kernel.org
Cc: davem@...emloft.net, adham.abozaeid@...rochip.com,
 claudiu.beznea@...on.dev, conor+dt@...nel.org, edumazet@...gle.com,
 kuba@...nel.org, kvalo@...nel.org, krzk+dt@...nel.org, pabeni@...hat.com,
 robh@...nel.org, devicetree@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] wifi: wilc1000: Rework bus locking

On 11/16/24 8:57 PM, Marek Vasut wrote:
> On 11/15/24 9:04 PM, Ajay.Kathat@...rochip.com wrote:
> 
> Hello Ajay,
> 
>>>>>> Can you explain how to prevent that or shall we disable uAPSD
>>>>>> altogether ?
>>>>>
>>>>> Could you please share the test procedure and logs. I am occupied 
>>>>> at the
>>>>> moment but I shall make some time to look into it and get a better
>>>>> understanding.
>>>>
>>>> The simplest test procedure is this:
>>>>
>>>> $ while true ; do ifconfig wlan0 up ; ifconfig wlan0 down ; done
>>>>
>>>> As for the logs, MMCI controller sporadically reports either Command or
>>>> Data CRC error, so likely the SDIO response (from WILC to Host) is
>>>> corrupted.
>>>
>>> Are there any news ?
>>
>> I did test the same procedure in my setup, but I couldn't reproduce 
>> this issue
>> even after running it for a long duration. In my test setup, I used the
>> sama5d27-som1-ek1 host and wilc3000 firmware version 16.3.
>>
>> I think this issue could be related to the host MMCI controller driver.
>> Normally, the wilc SDIO bus failures are captured by driver logs with 
>> an error
>> code (e.g., timeout), but if the MMCI controller is outputting the 
>> warning
>> message, then the error could be related to it. Does the MMCI 
>> controller error
>> point to any specific function?
> 
> Either CMD52 or CMD53 errors out with CRC error, this is recognized by 
> the controller. That points to sporadic CRC error during SDIO transfer.
> 
>> Which host was used to test this scenario, and
>> is it possible to test with different host or different configuration 
>> on the
>> same host
> 
> I am observing sporadic command and data CRC errors on STM32MP157F 
> system with SDIO WILC3000.
> 
> , like disabling power save on the host?
> I already tested disabling power save.
> 
> Can you explain why does uAPSD (iw ...set power_save off) adversely 
> affect SDIO bus stability ?
> 
> Can you explain how to prevent that or shall we disable uAPSD altogether ?
> 
> Is there any way to make the WILC firmware produce debug output , so we 
> can figure out what is going on "on the other side" ?
> 
> Are you able to provide me (maybe off-list) some debug firmware build ?
> (or can I get firmware sources and build and debug my own WILC firmware 
> on the Cortus CPU?)
> 
> I can trigger the SDIO errors even without being connected to any AP , 
> so this is something between the WILC and the SDIO host, the radio is 
> likely not involved , right ?

Any news ?