netdev - Re: [PATCH net-next, v3] netlink: add IGMP/MLD join/leave notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202411220556.9IxBYuBa-lkp@intel.com>
Date: Fri, 22 Nov 2024 05:33:30 +0800
From: kernel test robot <lkp@...el.com>
To: Yuyang Huang <yuyanghuang@...gle.com>
Cc: oe-kbuild-all@...ts.linux.dev, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>,
	roopa@...ulusnetworks.com, jiri@...nulli.us,
	stephen@...workplumber.org, jimictw@...gle.com, prohr@...gle.com,
	liuhangbin@...il.com, nicolas.dichtel@...nd.com, andrew@...n.ch,
	netdev@...r.kernel.org,
	Maciej Żenczykowski <maze@...gle.com>,
	Lorenzo Colitti <lorenzo@...gle.com>,
	Patrick Ruddy <pruddy@...tta.att-mail.com>
Subject: Re: [PATCH net-next, v3] netlink: add IGMP/MLD join/leave
 notifications

Hi Yuyang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on v6.12]
[also build test WARNING on next-20241121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuyang-Huang/netlink-add-IGMP-MLD-join-leave-notifications/20241121-154542
base:   v6.12
patch link:    https://lore.kernel.org/r/20241121054711.818670-1-yuyanghuang%40google.com
patch subject: [PATCH net-next, v3] netlink: add IGMP/MLD join/leave notifications
config: parisc-defconfig (https://download.01.org/0day-ci/archive/20241122/202411220556.9IxBYuBa-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220556.9IxBYuBa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411220556.9IxBYuBa-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/ipv6/mcast.c: In function 'inet6_fill_ifmcaddr':
>> net/ipv6/mcast.c:912:12: warning: unused variable 'scope' [-Wunused-variable]
     912 |         u8 scope;
         |            ^~~~~


vim +/scope +912 net/ipv6/mcast.c

   906	
   907	static int inet6_fill_ifmcaddr(struct sk_buff *skb, struct net_device *dev,
   908				       const struct in6_addr *addr, int event)
   909	{
   910		struct ifaddrmsg *ifm;
   911		struct nlmsghdr *nlh;
 > 912		u8 scope;
   913	
   914		nlh = nlmsg_put(skb, 0, 0, event, sizeof(struct ifaddrmsg), 0);
   915		if (!nlh)
   916			return -EMSGSIZE;
   917	
   918		ifm = nlmsg_data(nlh);
   919		ifm->ifa_family = AF_INET6;
   920		ifm->ifa_prefixlen = 128;
   921		ifm->ifa_flags = IFA_F_PERMANENT;
   922		ifm->ifa_scope = RT_SCOPE_UNIVERSE;
   923		ifm->ifa_index = dev->ifindex;
   924	
   925		if (nla_put_in6_addr(skb, IFA_MULTICAST, addr) < 0) {
   926			nlmsg_cancel(skb, nlh);
   927			return -EMSGSIZE;
   928		}
   929	
   930		nlmsg_end(skb, nlh);
   931		return 0;
   932	}
   933	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki