netdev - Re: [PATCH bpf 0/4] bpf, vsock: Fix poll() and close()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <673fc371c9de1_11182089c@john.notmuch>
Date: Thu, 21 Nov 2024 15:34:09 -0800
From: John Fastabend <john.fastabend@...il.com>
To: Stefano Garzarella <sgarzare@...hat.com>, 
 John Fastabend <john.fastabend@...il.com>
Cc: Michal Luczaj <mhal@...x.co>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>, 
 Bobby Eshleman <bobby.eshleman@...edance.com>, 
 "Michael S. Tsirkin" <mst@...hat.com>, 
 Alexei Starovoitov <ast@...nel.org>, 
 Daniel Borkmann <daniel@...earbox.net>, 
 Andrii Nakryiko <andrii@...nel.org>, 
 Martin KaFai Lau <martin.lau@...ux.dev>, 
 Eduard Zingerman <eddyz87@...il.com>, 
 Song Liu <song@...nel.org>, 
 Yonghong Song <yonghong.song@...ux.dev>, 
 KP Singh <kpsingh@...nel.org>, 
 Stanislav Fomichev <sdf@...ichev.me>, 
 Hao Luo <haoluo@...gle.com>, 
 Jiri Olsa <jolsa@...nel.org>, 
 Mykola Lysenko <mykolal@...com>, 
 Shuah Khan <shuah@...nel.org>, 
 netdev@...r.kernel.org, 
 bpf@...r.kernel.org, 
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf 0/4] bpf, vsock: Fix poll() and close()

Stefano Garzarella wrote:
> On Wed, Nov 20, 2024 at 10:48:25PM -0800, John Fastabend wrote:
> >Michal Luczaj wrote:
> >> Two small fixes for vsock: poll() missing a queue check, and close() not
> >> invoking sockmap cleanup.
> >>
> >> Signed-off-by: Michal Luczaj <mhal@...x.co>
> >> ---
> >> Michal Luczaj (4):
> >>       bpf, vsock: Fix poll() missing a queue
> >>       selftest/bpf: Add test for af_vsock poll()
> >>       bpf, vsock: Invoke proto::close on close()
> >>       selftest/bpf: Add test for vsock removal from sockmap on close()
> >>
> >>  net/vmw_vsock/af_vsock.c                           | 70 ++++++++++++--------
> >>  .../selftests/bpf/prog_tests/sockmap_basic.c       | 77 ++++++++++++++++++++++
> >>  2 files changed, 120 insertions(+), 27 deletions(-)
> >> ---
> >> base-commit: 6c4139b0f19b7397286897caee379f8321e78272
> >> change-id: 20241118-vsock-bpf-poll-close-64f432e682ec
> >>
> >> Best regards,
> >> --
> >> Michal Luczaj <mhal@...x.co>
> >>
> >
> >LGTM, would be nice to get an ack from someone on the vsock side
> >though.
> 
> Sorry, is at the top of my list but other urgent things have come up.
> 
> I will review it by today.

Thanks a lot Stefano much appreciated! I was also slow to review as I
was travelling and on PTO.

> 
> Stefano
> 
> >
> >Acked-by: John Fastabend <john.fastabend@...il.com>
> >
>