netdev - Re: [PATCH] xfrm: add SA information to the offloaded packet when if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d487b58-6850-499c-a131-b8169061759a@redhat.com>
Date: Thu, 21 Nov 2024 09:09:24 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Feng Wang <wangfe@...gle.com>, netdev@...r.kernel.org,
 steffen.klassert@...unet.com, antony.antony@...unet.com, leonro@...dia.com
Subject: Re: [PATCH] xfrm: add SA information to the offloaded packet when
 if_id is set

Hi,

On 11/19/24 23:04, Feng Wang wrote:
> From: wangfe <wangfe@...gle.com>

Unneeded, since the author (you) matches the submitter email address
(yours).

BTW please include a patch revision number into the subj prefix to help
reviewers.

> @@ -240,6 +256,7 @@ bool nsim_ipsec_tx(struct netdevsim *ns, struct sk_buff *skb)
>  	struct xfrm_state *xs;
>  	struct nsim_sa *tsa;
>  	u32 sa_idx;
> +	struct xfrm_offload *xo;

This is network driver code, please respect the reverse x-mas tree order
above.

> diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
> index e5722c95b8bb..59ac45f0c4ac 100644
> --- a/net/xfrm/xfrm_output.c
> +++ b/net/xfrm/xfrm_output.c
> @@ -706,6 +706,8 @@ int xfrm_output(struct sock *sk, struct sk_buff *skb)
>  	struct xfrm_state *x = skb_dst(skb)->xfrm;
>  	int family;
>  	int err;
> +	struct xfrm_offload *xo;
> +	struct sec_path *sp;

I see the xfrm subtree is more relaxed with the reverse x-mas tree
order, but for consistency I would respect it even here.

Cheers,

Paolo