netdev - Re: [PATCH 1/2] PCI/MSI: Add MSIX option to write to ENTRY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a292cdfe-e319-4bbd-bcc0-a74c16db9053@redhat.com>
Date: Thu, 21 Nov 2024 09:55:47 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: dullfire@...oo.com, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Jacob Keller
 <jacob.e.keller@...el.com>, Simon Horman <horms@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>, Mostafa Saleh <smostafa@...gle.com>,
 Marc Zyngier <maz@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH 1/2] PCI/MSI: Add MSIX option to write to ENTRY_DATA
 before any reads

On 11/18/24 00:48, dullfire@...oo.com wrote:
> From: Jonathan Currier <dullfire@...oo.com>
> 
> Commit 7d5ec3d36123 ("PCI/MSI: Mask all unused MSI-X entries")
> introduces a readl() from ENTRY_VECTOR_CTRL before the writel() to
> ENTRY_DATA. This is correct, however some hardware, like the Sun Neptune
> chips, the niu module, will cause an error and/or fatal trap if any MSIX
> table entry is read before the corresponding ENTRY_DATA field is written
> to. This patch adds an optional early writel() in msix_prepare_msi_desc().

Why the issue can't be addressed into the relevant device driver? It
looks like an H/W bug, a driver specific fix looks IMHO more fitting.

A cross subsystem series, like this one, gives some extra complication
to maintainers.

Thanks,

Paolo