netdev - Re: [PATCH net-next v2 00/21] net:yt6801: Add Motorcomm yt6801 PCIe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78774ff4-2eba-4810-ae44-126756418103@lunn.ch>
Date: Fri, 22 Nov 2024 23:14:10 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Frank Sae <Frank.Sae@...or-comm.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, xiaogang.fan@...or-comm.com,
	fei.zhang@...or-comm.com, hua.sun@...or-comm.com
Subject: Re: [PATCH net-next v2 00/21] net:yt6801: Add Motorcomm yt6801 PCIe
 driver

On Wed, Nov 20, 2024 at 06:56:04PM +0800, Frank Sae wrote:
> This series includes adding Motorcomm YT6801 Gigabit ethernet driver
> and adding yt6801 ethernet driver entry in MAINTAINERS file.
> 
> YT6801 integrates a YT8531S phy.
> 
> v1 -> v2:
> - Split this driver into multiple patches.
> - Reorganize this driver code and remove redundant code
> - Remove PHY handling code and use phylib.
> - Remove writing ASPM config
> - Use generic power management instead of pci_driver.suspend()/resume()
> - Add Space before closing "*/"

Looking quickly through the code, i see a lot of yt_dbg(), many more
than typical. It makes it feel like you are still debugging this
driver.

Please consider removing most of them.

	Andrew