netdev - Re: [PATCH net 1/3] ipmr: add debug check for mr table cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05cb7a72-5954-4c0a-ad4c-250d18a12ba9@redhat.com>
Date: Fri, 22 Nov 2024 14:04:35 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: netdev@...r.kernel.org
Cc: Eric Dumazet <edumazet@...gle.com>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>, stefan.wiehler@...ia.com
Subject: Re: [PATCH net 1/3] ipmr: add debug check for mr table cleanup

On 11/22/24 12:02, Paolo Abeni wrote:
> diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
> index c58dd78509a2..c6ad01dc8310 100644
> --- a/net/ipv4/ipmr.c
> +++ b/net/ipv4/ipmr.c
> @@ -358,6 +358,11 @@ bool ipmr_rule_default(const struct fib_rule *rule)
>  EXPORT_SYMBOL(ipmr_rule_default);
>  #endif
>  
> +static bool ipmr_can_free_table(struct net *net)
> +{
> +	return !check_net(net) || !net->ipv4.mr_rules_ops;

Not so good. mr_rules_ops exists only for
CONFIG_IP_MROUTE_MULTIPLE_TABLES builds.

/P