netdev - RE: [Intel-wired-lan] [PATCH iwl-net] ice: Fix VLAN pruning in switchdev mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5009F426224EF8CDF80B0E4D96232@CO1PR11MB5009.namprd11.prod.outlook.com>
Date: Fri, 22 Nov 2024 13:17:18 +0000
From: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>
To: Marcin Szycik <marcin.szycik@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>, "Singh, PriyaX"
	<priyax.singh@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] ice: Fix VLAN pruning in
 switchdev mode

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Marcin Szycik
> Sent: Tuesday, November 5, 2024 12:19 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Marcin Szycik <marcin.szycik@...ux.intel.com>;
> Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix VLAN pruning in switchdev
> mode
> 
> In switchdev mode the uplink VSI should receive all unmatched packets,
> including VLANs. Therefore, VLAN pruning should be disabled if uplink is in
> switchdev mode. It is already being done in ice_eswitch_setup_env(),
> however the addition of ice_up() in commit 44ba608db509 ("ice: do
> switchdev slow-path Rx using PF VSI") caused VLAN pruning to be re-enabled
> after disabling it.
> 
> Add a check to ice_set_vlan_filtering_features() to ensure VLAN filtering will
> not be enabled if uplink is in switchdev mode. Note that
> ice_is_eswitch_mode_switchdev() is being used instead of
> ice_is_switchdev_running(), as the latter would only return true after the
> whole switchdev setup completes.
> 
> Fixes: 44ba608db509 ("ice: do switchdev slow-path Rx using PF VSI")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Tested-by: Singh, PriyaX <priyax.singh@...el.com>