netdev - Re: [PATCH net] selftests: rds: move include.sh to TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241122150129.GB18887@dev-dsk-mheyne-1b-55676e6a.eu-west-1.amazon.com>
Date: Fri, 22 Nov 2024 15:01:29 +0000
From: Maximilian Heyne <mheyne@...zon.de>
To: Hangbin Liu <liuhangbin@...il.com>
CC: <netdev@...r.kernel.org>, Allison Henderson
	<allison.henderson@...cle.com>, "David S. Miller" <davem@...emloft.net>,
	"Eric Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, Vegard Nossum
	<vegard.nossum@...cle.com>, Chuck Lever <chuck.lever@...cle.com>,
	<linux-rdma@...r.kernel.org>, <rds-devel@....oracle.com>,
	<linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] selftests: rds: move include.sh to TEST_FILES

Hi Hangbin,

On Fri, Sep 27, 2024 at 12:13:49PM +0800, Hangbin Liu wrote:
> The include.sh file is generated for inclusion and should not be executable.
> Otherwise, it will be added to kselftest-list.txt. Additionally, add the
> executable bit for test.py at the same time to ensure proper functionality.
> 
> Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/rds/Makefile | 3 ++-
>  tools/testing/selftests/net/rds/test.py  | 0
>  2 files changed, 2 insertions(+), 1 deletion(-)
>  mode change 100644 => 100755 tools/testing/selftests/net/rds/test.py
> 
> diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
> index da9714bc7aad..cf30307a829b 100644
> --- a/tools/testing/selftests/net/rds/Makefile
> +++ b/tools/testing/selftests/net/rds/Makefile
> @@ -4,9 +4,10 @@ all:
>  	@echo mk_build_dir="$(shell pwd)" > include.sh
>  
>  TEST_PROGS := run.sh \
> -	include.sh \
>  	test.py

Should test.py also move down to TEST_FILES? I think run.sh is executing
test.py anyway but does a couple of sanity checks before, so I think
this it's not necessary to let the runner execute test.py standalone.

>  
> +TEST_FILES := include.sh
> +
>  EXTRA_CLEAN := /tmp/rds_logs
>  
>  include ../../lib.mk
> diff --git a/tools/testing/selftests/net/rds/test.py b/tools/testing/selftests/net/rds/test.py
> old mode 100644
> new mode 100755
> -- 
> 2.39.3 (Apple Git-146)
> 

Thanks,
Max



Amazon Web Services Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597