netdev - Re: [PATCH bpf 1/4] bpf, vsock: Fix poll() missing a queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241122172629.62588-1-leonardi@redhat.com>
Date: Fri, 22 Nov 2024 18:26:29 +0100
From: Luigi Leonardi <leonardi@...hat.com>
To: mhal@...x.co
Cc: andrii@...nel.org,
	ast@...nel.org,
	bobby.eshleman@...edance.com,
	bpf@...r.kernel.org,
	daniel@...earbox.net,
	davem@...emloft.net,
	eddyz87@...il.com,
	edumazet@...gle.com,
	haoluo@...gle.com,
	horms@...nel.org,
	john.fastabend@...il.com,
	jolsa@...nel.org,
	kpsingh@...nel.org,
	kuba@...nel.org,
	linux-kselftest@...r.kernel.org,
	martin.lau@...ux.dev,
	mst@...hat.com,
	mykolal@...com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	sdf@...ichev.me,
	sgarzare@...hat.com,
	shuah@...nel.org,
	song@...nel.org,
	yonghong.song@...ux.dev,
	Luigi Leonardi <leonardi@...hat.com>
Subject: Re: [PATCH bpf 1/4] bpf, vsock: Fix poll() missing a queue

>When a verdict program simply passes a packet without redirection, sk_msg
>is enqueued on sk_psock::ingress_msg. Add a missing check to poll().
>
>Fixes: 634f1a7110b4 ("vsock: support sockmap")
>Signed-off-by: Michal Luczaj <mhal@...x.co>
>---
> net/vmw_vsock/af_vsock.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
>index dfd29160fe11c4675f872c1ee123d65b2da0dae6..919da8edd03c838cbcdbf1618425da6c5ec2df1a 100644
>--- a/net/vmw_vsock/af_vsock.c
>+++ b/net/vmw_vsock/af_vsock.c
>@@ -1054,6 +1054,9 @@ static __poll_t vsock_poll(struct file *file, struct socket *sock,
> 		mask |= EPOLLRDHUP;
> 	}
> 
>+	if (sk_is_readable(sk))
>+		mask |= EPOLLIN | EPOLLRDNORM;
>+
> 	if (sock->type == SOCK_DGRAM) {
> 		/* For datagram sockets we can read if there is something in
> 		 * the queue and write as long as the socket isn't shutdown for

LGTM, thanks!

Reviewed-by: Luigi Leonardi <leonardi@...hat.com>