netdev - Re: [PATCH net-next 1/5] net: ethtool: only allow set_rxnfc with rss + ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be6cf399-deeb-f879-057d-baf9c4e76863@gmail.com>
Date: Mon, 25 Nov 2024 18:13:21 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Gal Pressman <gal@...dia.com>, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com,
 Ahmed Zaki <ahmed.zaki@...el.com>
Cc: netdev@...r.kernel.org, habetsm.xilinx@...il.com,
 linux-net-drivers@....com, horms@...nel.org, andrew+netdev@...n.ch,
 shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 1/5] net: ethtool: only allow set_rxnfc with rss
 + ring_cookie if driver opts in

On 25/11/2024 14:10, Gal Pressman wrote:
> Thanks, I did not know it works that way, is it actually documented
> anywhere?

Yes; the struct ethtool_rxnfc kerneldoc has:
 * For %ETHTOOL_SRXCLSRLINS, @fs specifies the rule to add or update.
 * @fs.@...ation either specifies the location to use or is a special
 * location value with %RX_CLS_LOC_SPECIAL flag set.  On return,
 * @fs.@...ation is the actual rule location.  If @fs.@...w_type
 * includes the %FLOW_RSS flag, @rss_context is the RSS context ID to
 * use for flow spreading traffic which matches this rule.  The value
 * from the rxfh indirection table will be added to @fs.@...g_cookie
 * to choose which ring to deliver to.

I am also preparing a patch to add this info to the ethtool man page.