netdev - Re: [PATCH net v1 1/1] net: phy: microchip: Reset LAN88xx PHY to ensure clean link state on LAN7800/7850

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241124163418.7d97a19b@kernel.org>
Date: Sun, 24 Nov 2024 16:34:18 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
 Eric Dumazet <edumazet@...gle.com>, Florian Fainelli
 <f.fainelli@...il.com>, Paolo Abeni <pabeni@...hat.com>, Woojung Huh
 <woojung.huh@...rochip.com>, Arun Ramadoss <arun.ramadoss@...rochip.com>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Yuiko Oshino <yuiko.oshino@...rochip.com>,
 kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com, Phil Elwell
 <phil@...pberrypi.org>
Subject: Re: [PATCH net v1 1/1] net: phy: microchip: Reset LAN88xx PHY to
 ensure clean link state on LAN7800/7850

On Sun, 17 Nov 2024 11:21:47 +0100 Oleksij Rempel wrote:
> +	/* Reset PHY, otherwise MII_LPA will provide outdated information.
> +	 * This issue is reproducible only with after parallel detection
> +	 * where link partner do not supports auto-negotiation.

sorry for late nit, the comment needs a bit better grammar

	 * This issue is reproducible only with after parallel detection
	                                   ^^^^^^^^^^ ?
	 * where link partner do not supports auto-negotiation.
                              ^^^^^^^^^^^^^^^
	                      does not support ?
-- 
pw-bot: cr