netdev - Re: rhashtable issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0PKQGcuT43tbbT8@gondor.apana.org.au>
Date: Mon, 25 Nov 2024 08:52:16 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: NeilBrown <neilb@...e.de>, Thomas Graf <tgraf@...g.ch>,
	netdev@...r.kernel.org
Subject: Re: rhashtable issue - -EBUSY

On Sun, Nov 24, 2024 at 06:58:12PM -0500, Kent Overstreet wrote:
>
> Sorry for claiming this was your bug - I do agree with Neal that the
> rhastable code could handle this situation better though, so as to avoid
> crazy bughunts.

Yes it could certainly make this more obvious.  How about a
WARN_ON_ONCE if we detect two identical keys? That should have
made this more obvious.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt