netdev - Re: [PATCH v2 net 2/3] ip6mr: fix tables suspicious RCU usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57614d75-7f44-40be-8078-cc4a0773a0cd@kernel.org>
Date: Tue, 26 Nov 2024 08:39:44 -0700
From: David Ahern <dsahern@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Eric Dumazet <edumazet@...gle.com>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>, stefan.wiehler@...ia.com
Subject: Re: [PATCH v2 net 2/3] ip6mr: fix tables suspicious RCU usage

On 11/24/24 8:40 AM, Paolo Abeni wrote:
> Several places call ip6mr_get_table() with no RCU nor RTNL lock.
> Add RCU protection inside such helper and provide a lockless variant
> for the few callers that already acquired the relevant lock.
> 
> Note that some users additionally reference the table outside the RCU
> lock. That is actually safe as the table deletion can happen only
> after all table accesses are completed.
> 
> Fixes: e2d57766e674 ("net: Provide compat support for SIOCGETMIFCNT_IN6 and SIOCGETSGCNT_IN6.")
> Fixes: d7c31cbde4bc ("net: ip6mr: add RTM_GETROUTE netlink op")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  net/ipv6/ip6mr.c | 38 +++++++++++++++++++++++++++-----------
>  1 file changed, 27 insertions(+), 11 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>