netdev - Re: [PATCH net v2] net: Fix icmp host relookup triggering ip_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4477a20-8f35-43de-a7f9-a0c7570248cc@kernel.org>
Date: Tue, 26 Nov 2024 09:23:04 -0700
From: David Ahern <dsahern@...nel.org>
To: Dong Chenchen <dongchenchen2@...wei.com>, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org,
 herbert@...dor.apana.org.au, steffen.klassert@...unet.com
Cc: netdev@...r.kernel.org, yuehaibing@...wei.com, zhangchangzhong@...wei.com
Subject: Re: [PATCH net v2] net: Fix icmp host relookup triggering ip_rt_bug

On 11/25/24 7:59 PM, Dong Chenchen wrote:
> diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
> index 4f088fa1c2f2..0d51f8434187 100644
> --- a/net/ipv4/icmp.c
> +++ b/net/ipv4/icmp.c
> @@ -515,7 +515,10 @@ static struct rtable *icmp_route_lookup(struct net *net, struct flowi4 *fl4,
>  			  flowi4_to_flowi(fl4), NULL, 0);
>  	rt = dst_rtable(dst);
>  	if (!IS_ERR(dst)) {
> -		if (rt != rt2)
> +		unsigned int addr_type = inet_addr_type_dev_table(net,
> +							route_lookup_dev, fl4->daddr);
> +

	unsigned int addr_type;

	addr_type = inet_addr_type_dev_table(net, route_lookup_dev,
                                             fl4->daddr);

allows the lines to meet column limits and alignment requirements.

> +		if (rt != rt2 || addr_type == RTN_LOCAL)
>  			return rt;
>  	} else if (PTR_ERR(dst) == -EPERM) {
>  		rt = NULL;