netdev - Re: rhashtable issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0VHwWe8x9RrhKGp@gondor.apana.org.au>
Date: Tue, 26 Nov 2024 12:00:01 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: NeilBrown <neilb@...e.de>, Thomas Graf <tgraf@...g.ch>,
	netdev@...r.kernel.org
Subject: Re: rhashtable issue - -EBUSY

On Mon, Nov 25, 2024 at 10:51:04PM -0500, Kent Overstreet wrote:
>
> I just meant having a knob that's called "insecure". Why not a knob
> that selects nonblocking vs. reliable?

Because it is *insecure*.  If a hostile actor gains the ability
to insert into your hash table, then by disabling this defence
you're giving them the ability to turn your hash table into a
linked list.

So as long as you acknowledge and are willing to undertake this
risk, I'm happy for you to do that.  But I'm not going to hide
this under the rug.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt