netdev - Re: [PATCH] ptp: Add error handling for adjfine callback in ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z0VREVDLnYhIy0UH@hoboy.vegasvil.org>
Date: Mon, 25 Nov 2024 20:39:45 -0800
From: Richard Cochran <richardcochran@...il.com>
To: Ajay Kaher <ajay.kaher@...adcom.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	nick.shi@...adcom.com, alexey.makhalov@...adcom.com,
	vasavi.sirnapalli@...adcom.com,
	vamsi-krishna.brahmajosyula@...adcom.com,
	florian.fainelli@...adcom.com
Subject: Re: [PATCH]  ptp: Add error handling for adjfine callback in
 ptp_clock_adjtime

On Mon, Nov 25, 2024 at 10:59:54AM +0000, Ajay Kaher wrote:
> ptp_clock_adjtime sets ptp->dialed_frequency even when adjfine
> callback returns an error. This causes subsequent reads to return
> an incorrect value.
> 
> Fix this by adding error check before ptp->dialed_frequency is set.
> 
> Fixes: 39a8cbd9ca05 ("ptp: remember the adjusted frequency")
> Signed-off-by: Ajay Kaher <ajay.kaher@...adcom.com>

Acked-by: Richard Cochran <richardcochran@...il.com>