netdev - Re: [PATCH net v1 2/3] bnxt_en: refactor bnxt_alloc_rx_rings() to call bnxt_alloc_rx_agg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOBf=muRZ2SDeadY8Sjass8tZ3xM5iCYeJjEMDLgCZXnCoLOcg@mail.gmail.com>
Date: Tue, 26 Nov 2024 12:01:42 +0530
From: Somnath Kotur <somnath.kotur@...adcom.com>
To: David Wei <dw@...idwei.uk>
Cc: netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>, 
	Andy Gospodarek <andrew.gospodarek@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v1 2/3] bnxt_en: refactor bnxt_alloc_rx_rings() to
 call bnxt_alloc_rx_agg_bmap()

On Mon, Nov 25, 2024 at 9:54 AM David Wei <dw@...idwei.uk> wrote:
>
> Refactor bnxt_alloc_rx_rings() to call bnxt_alloc_rx_agg_bmap() for
> allocating rx_agg_bmap.
>
> Signed-off-by: David Wei <dw@...idwei.uk>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 36 ++++++++++-------------
>  1 file changed, 16 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index b2cc8df22241..294d21cdaeb7 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -3768,6 +3768,19 @@ static int bnxt_alloc_rx_page_pool(struct bnxt *bp,
>         return PTR_ERR(pool);
>  }
>
> +static int bnxt_alloc_rx_agg_bmap(struct bnxt *bp, struct bnxt_rx_ring_info *rxr)
> +{
> +       u16 mem_size;
> +
> +       rxr->rx_agg_bmap_size = bp->rx_agg_ring_mask + 1;
> +       mem_size = rxr->rx_agg_bmap_size / 8;
> +       rxr->rx_agg_bmap = kzalloc(mem_size, GFP_KERNEL);
> +       if (!rxr->rx_agg_bmap)
> +               return -ENOMEM;
> +
> +       return 0;
> +}
> +
>  static int bnxt_alloc_rx_rings(struct bnxt *bp)
>  {
>         int numa_node = dev_to_node(&bp->pdev->dev);
> @@ -3812,19 +3825,15 @@ static int bnxt_alloc_rx_rings(struct bnxt *bp)
>
>                 ring->grp_idx = i;
>                 if (agg_rings) {
> -                       u16 mem_size;
> -
>                         ring = &rxr->rx_agg_ring_struct;
>                         rc = bnxt_alloc_ring(bp, &ring->ring_mem);
>                         if (rc)
>                                 return rc;
>
>                         ring->grp_idx = i;
> -                       rxr->rx_agg_bmap_size = bp->rx_agg_ring_mask + 1;
> -                       mem_size = rxr->rx_agg_bmap_size / 8;
> -                       rxr->rx_agg_bmap = kzalloc(mem_size, GFP_KERNEL);
> -                       if (!rxr->rx_agg_bmap)
> -                               return -ENOMEM;
> +                       rc = bnxt_alloc_rx_agg_bmap(bp, rxr);
> +                       if (rc)
> +                               return rc;
>                 }
>         }
>         if (bp->flags & BNXT_FLAG_TPA)
> @@ -15321,19 +15330,6 @@ static const struct netdev_stat_ops bnxt_stat_ops = {
>         .get_base_stats         = bnxt_get_base_stats,
>  };
>
> -static int bnxt_alloc_rx_agg_bmap(struct bnxt *bp, struct bnxt_rx_ring_info *rxr)
> -{
> -       u16 mem_size;
> -
> -       rxr->rx_agg_bmap_size = bp->rx_agg_ring_mask + 1;
> -       mem_size = rxr->rx_agg_bmap_size / 8;
> -       rxr->rx_agg_bmap = kzalloc(mem_size, GFP_KERNEL);
> -       if (!rxr->rx_agg_bmap)
> -               return -ENOMEM;
> -
> -       return 0;
> -}
> -
>  static int bnxt_queue_mem_alloc(struct net_device *dev, void *qmem, int idx)
>  {
>         struct bnxt_rx_ring_info *rxr, *clone;
> --
> 2.43.5
>
>
Reviewed-by: Somnath Kotur <somnath.kotur@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)