netdev - Re: [PATCH iproute2 v2] bridge: fix memory leak in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80c68c36-8d24-4231-9808-f3d3b76a099f@blackwall.org>
Date: Tue, 26 Nov 2024 11:20:01 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Minhong He <heminhong@...inos.cn>
Cc: netdev@...r.kernel.org, stephen@...workplumber.org, roopa@...dia.com,
 bridge@...ts.linux-foundation.org
Subject: Re: [PATCH iproute2 v2] bridge: fix memory leak in error path

On 26/11/2024 04:18, Minhong He wrote:
> The 'json' object doesn't free when 'rtnl_dump_filter()' fails to process,
> fix it.
> 
> Signed-off-by: Minhong He <heminhong@...inos.cn>
> ---
>  bridge/mst.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/bridge/mst.c b/bridge/mst.c
> index 32f64aba..37362c45 100644
> --- a/bridge/mst.c
> +++ b/bridge/mst.c
> @@ -153,6 +153,7 @@ static int mst_show(int argc, char **argv)
>  
>  	if (rtnl_dump_filter(&rth, print_msts, stdout) < 0) {
>  		fprintf(stderr, "Dump terminated\n");
> +		delete_json_obj();
>  		return -1;
>  	}
>  

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>