netdev - Re: [PATCH net] tcp: populate XPS related fields of timewait sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241126020845.35087-1-kuniyu@amazon.com>
Date: Tue, 26 Nov 2024 11:08:45 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <brianvv@...gle.com>, <davem@...emloft.net>, <eric.dumazet@...il.com>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <syzbot+8b0959fc16551d55896b@...kaller.appspotmail.com>
Subject: Re: [PATCH net] tcp: populate XPS related fields of timewait sockets

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 25 Nov 2024 09:30:39 +0000
> syzbot reported that netdev_core_pick_tx() was reading an unitialized
> field [1].
> 
> This is indeed hapening for timewait sockets after recent commits.
> 
> We can copy the original established socket sk_tx_queue_mapping
> and sk_rx_queue_mapping fields, instead of adding more checks
> in fast paths.
> 
> As a bonus, packets will use the same transmit queue than
> prior ones, this potentially can avoid reordering.
[...]
> Fixes: 79636038d37e ("ipv4: tcp: give socket pointer to control skbs")
> Fixes: 507a96737d99 ("ipv6: tcp: give socket pointer to control skbs")
> Reported-by: syzbot+8b0959fc16551d55896b@...kaller.appspotmail.com
> Link: https://lore.kernel.org/netdev/674442bd.050a0220.1cc393.0072.GAE@google.com/T/#u
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Thanks!