netdev - 回覆: [PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB51349813139B962351E459F29D282@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Wed, 27 Nov 2024 03:57:05 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Philipp Zabel
	<p.zabel@...gutronix.de>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "ratbert@...aday-tech.com" <ratbert@...aday-tech.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Conor Dooley <conor.dooley@...rochip.com>
Subject:
 回覆: [PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700

Hi Krzysztof,

Thank you for your reply.

> >> diff --git
> >> a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> >> b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> >> index 9bcbacb6640d..fffe5c51daa9 100644
> >> --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> >> +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> >> @@ -21,6 +21,7 @@ properties:
> >>                - aspeed,ast2400-mac
> >>                - aspeed,ast2500-mac
> >>                - aspeed,ast2600-mac
> >> +              - aspeed,ast2700-mac
> >>            - const: faraday,ftgmac100
> >>
> >>    reg:
> >> @@ -33,7 +34,7 @@ properties:
> >>      minItems: 1
> >>      items:
> >>        - description: MAC IP clock
> >> -      - description: RMII RCLK gate for AST2500/2600
> >> +      - description: RMII RCLK gate for AST2500/2600/2700
> >>
> >>    clock-names:
> >>      minItems: 1
> >
> > Given patch 3, I would expect a resets property to be defined and
> > possibly added to the list of required properties for aspeed,ast2700-
> > mac.
> 
> 
> Yeah, DTS was not tested at all.
> 
> Jacky, where is the DTS, so we can validate it? Please provide link in cover
> letter.
> 

About the DTS of Aspeed g7, we have verified on our SDK and g7 platform.
Please refer to these links on our github.
https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v6.6/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
https://github.com/AspeedTech-BMC/linux/blob/aspeed-master-v6.6/arch/arm64/boot/dts/aspeed/ast2700-evb.dts

We are preparing to submit these DTS to mainline.

Thanks,
Jacky