netdev - RE: [PATCH net v5 3/3] rtase: Corrects error handling of the rtase_check_mac_version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d3ca2183d864f71b1ee1f8fc10527f8@realtek.com>
Date: Wed, 27 Nov 2024 07:08:35 +0000
From: Justin Lai <justinlai0215@...ltek.com>
To: Paolo Abeni <pabeni@...hat.com>, "kuba@...nel.org" <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "horms@...nel.org"
	<horms@...nel.org>,
        "michal.kubiak@...el.com" <michal.kubiak@...el.com>,
        Ping-Ke Shih <pkshih@...ltek.com>, Larry Chiu <larry.chiu@...ltek.com>
Subject: RE: [PATCH net v5 3/3] rtase: Corrects error handling of the rtase_check_mac_version_valid()

> 
> On 11/20/24 08:56, Justin Lai wrote:
> > Previously, when the hardware version ID was determined to be invalid,
> > only an error message was printed without any further handling.
> > Therefore, this patch makes the necessary corrections to address this.
> >
> > Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this
> > module")
> > Signed-off-by: Justin Lai <justinlai0215@...ltek.com>
> 
> Note that you should have retained the Acked-by tag provided by Andrew on
> v3.
> 
> No need to repost, I'm applying the series, but please keep in mind for the next
> submission.
> 
> Thanks,
> 
> Paolo

OK, I understand. Thanks for the review, I’ll follow this approach from
now on.

Justin