netdev - RE: [Intel-wired-lan] [PATCH v3 1/1] ixgbe: Correct BASE-BX10 compliance code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CYYPR11MB84293DF5A2E2CA581D7B0C32BD282@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Wed, 27 Nov 2024 10:24:31 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: Tore Amundsen <tore@...ndsen.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "ernesto@...tellotti.net" <ernesto@...tellotti.net>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"kuba@...nel.org" <kuba@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v3 1/1] ixgbe: Correct BASE-BX10
 compliance code

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Tore Amundsen
> Sent: 15 November 2024 19:48
> To: netdev@...r.kernel.org
> Cc: pmenzel@...gen.mpg.de; andrew+netdev@...n.ch; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; davem@...emloft.net; edumazet@...gle.com; ernesto@...tellotti.net; intel-wired-lan@...ts.osuosl.org; kuba@...nel.org; linux-kernel@...r.kernel.org; pabeni@...hat.com; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; tore@...ndsen.org
> Subject: [Intel-wired-lan] [PATCH v3 1/1] ixgbe: Correct BASE-BX10 compliance code
>
> SFF-8472 (section 5.4 Transceiver Compliance Codes) defines bit 6 as BASE-BX10. Bit 6 means a value of 0x40 (decimal 64).
>
> The current value in the source code is 0x64, which appears to be a mix-up of hex and decimal values. A value of 0x64 (binary 01100100) incorrectly sets bit 2 (1000BASE-CX) and bit 5 (100BASE-FX) as well.
>
> Fixes: 1b43e0d20f2d ("ixgbe: Add 1000BASE-BX support")
> Signed-off-by: Tore Amundsen <tore@...ndsen.org>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> Acked-by: Ernesto Castellotti <ernesto@...tellotti.net>
> ---
> v2: Added Fixes tag as requested by Paul Menzel.
> v3: Correct Fixes tag format and add Acked-By.
>
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)