netdev - Re: [RFC ethtool] ethtool: mock JSON output for --module-info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3272bbe-3b3d-496e-95c6-9a35d469b6e7@gmail.com>
Date: Wed, 27 Nov 2024 08:55:33 -0500
From: Daniel Zahka <daniel.zahka@...il.com>
To: Danielle Ratson <danieller@...dia.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Jakub Kicinski <kuba@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 "mkubecek@...e.cz" <mkubecek@...e.cz>
Subject: Re: [RFC ethtool] ethtool: mock JSON output for --module-info


On 11/27/24 3:11 AM, Danielle Ratson wrote:
> Hi,
>
> I am attaching the dump I already have implemented for both CMIS and SFF modules:
>
> $ sudo ethtool --json -m swp23
> [ {
>          "identifier": 24,
>          "identifier_description": "QSFP-DD Double Density 8X Pluggable Transceiver (INF-8628)",
>          "power_class": 5,
>          "max_power": 10.00,
>          "max_power_units": "W",
>          "connector": 40,
>          "connector_description": "MPO 1x16",
>          "cable_assembly_length": 0.00,
>          "cable_assembly_length_units": "m",
>          "tx_cdr_bypass_control": false,
>          "rx_cdr_bypass_control": false,
>          "tx_cdr": true,
>          "rx_cdr": true,
>          "transmitter_technology": 0,
>          "transmitter_technology_description": "850 nm VCSEL",
>          "length_(smf)": 0.00,
>          "length_(smf)_units": "km",
>          "length_(om5)": 0,
>          "length_(om5)_units": "m",
>          "length_(om4)": 100,
>          "length_(om4)_units": "m",
>          "length_(om3_50/125um)": 70,
>          "length_(om3_50/125um)_units": "m",
>          "length_(om2_50/125um)": 0,
>          "length_(om2_50/125um)_units": "m",
>          "revision_compliance": [
>              "major": 4,
>              "minor": 0 ],
>          "rx_loss_of_signal": [ "Yes","Yes","Yes","Yes","Yes","Yes","Yes","Yes" ],
>          "tx_loss_of_signal": "None",
>          "rx_loss_of_lock": "None",
>          "tx_loss_of_lock": "None",
>          "tx_fault": "None",
>          "module_state": 3,
>          "module_state_description": "ModuleReady",
>          "low_pwr_allow_request_hw": false,
>          "low_pwr_request_sw": false,
>          "module_temperature": 36.00,
>          "module_temperature_units": "degrees C",
>          "module_voltage": 3.00,
>          "module_voltage_units": "V",
>          "module_temperature_high_alarm": false,
>          "module_temperature_low_alarm": false,
>          "module_temperature_high_warning": false,
>          "module_temperature_low_warning": false,
>          "module_voltage_high_alarm": false,
>          "module_voltage_low_alarm": false,
>          "module_voltage_high_warning": false,
>          "module_voltage_low_warning": false,
>          "cdb_instances": 1,
>          "cdb_background_mode": "Supported",
>          "cdb_epl_pages": 0,
>          "cdb_maximum_epl_rw_length": 128,
>          "cdb_maximum_lpl_rw_length": 128,
>          "cdb_trigger_method": "Single write"
>      } ]
>
> $ sudo ethtool --json -m swp1
> [ {
>          "identifier": 24,
>          "identifier_description": "QSFP-DD Double Density 8X Pluggable Transceiver (INF-8628)",
>          "power_class": 1,
>          "max_power": 0.25,
>          "max_power_units": "W",
>          "connector": 35,
>          "connector_description": "No separable connector",
>          "cable_assembly_length": 0.50,
>          "cable_assembly_length_units": "m",
>          "transmitter_technology": 10,
>          "transmitter_technology_description": "Copper cable, unequalized",
>          "attenuation_at_5ghz": 3,
>          "attenuation_at_5ghz_units": "db",
>          "attenuation_at_7ghz": 4,
>          "attenuation_at_7ghz_units": "db",
>          "attenuation_at_12.9ghz": 6,
>          "attenuation_at_12.9ghz_units": "db",
>          "attenuation_at_25.8ghz": 16,
>          "attenuation_at_25.8ghz_units": "db",
>          "revision_compliance": [
>              "major": 4,
>              "minor": 0 ],
>          "module_state": 3,
>          "module_state_description": "ModuleReady",
>          "low_pwr_allow_request_hw": false,
>          "low_pwr_request_sw": false
>      } ]
>
> Please let me know what do you think.


The formatting LGTM. It seems like some of the fields from upper page 
00h are missing: vendor name, vendor pn, etc. Are those elided because 
they are null?

>
> I believe I will send a version about two weeks from now.


Sounds good. Thanks for the update.