netdev - RE: [Intel-wired-lan] [PATCH v4 iwl-net 4/4] ice: Add correct PHY lane assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CYYPR11MB8429810875B1584896FEFED7BD292@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Thu, 28 Nov 2024 07:15:15 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Nitka, Grzegorz" <grzegorz.nitka@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kubalewski, Arkadiusz"
	<arkadiusz.kubalewski@...el.com>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v4 iwl-net 4/4] ice: Add correct PHY
 lane assignment

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Grzegorz Nitka
> Sent: 05 November 2024 17:59
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Kubalewski, Arkadiusz <arkadiusz.kubalewski@...el.com>; Kolacinski, Karol <karol.kolacinski@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH v4 iwl-net 4/4] ice: Add correct PHY lane assignment
>
> From: Karol Kolacinski <karol.kolacinski@...el.com>
>
> Driver always naively assumes, that for PTP purposes, PHY lane to configure is corresponding to PF ID.
>
> This is not true for some port configurations, e.g.:
> - 2x50G per quad, where lanes used are 0 and 2 on each quad, but PF IDs
>   are 0 and 1
> - 100G per quad on 2 quads, where lanes used are 0 and 4, but PF IDs are
>   0 and 1
>
> Use correct PHY lane assignment by getting and parsing port options.
> This is read from the NVM by the FW and provided to the driver with the indication of active port split.
>
> Remove ice_is_muxed_topo(), which is no longer needed.
>
> Fixes: 4409ea1726cb ("ice: Adjust PTP init for 2x50G E825C devices")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Arkadiusz Kubalewski <Arkadiusz.kubalewski@...el.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@...el.com>
> ---
> V1 -> V3: Added checker for speed value in returned AQ Get Options
>
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  1 +
>  drivers/net/ethernet/intel/ice/ice_common.c   | 45 +++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_common.h   |  1 +
>  drivers/net/ethernet/intel/ice/ice_main.c     |  6 +--
>  drivers/net/ethernet/intel/ice/ice_ptp.c      | 23 ++++------
>  drivers/net/ethernet/intel/ice/ice_ptp.h      |  4 +-
>  drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 26 +----------
>  drivers/net/ethernet/intel/ice/ice_type.h     |  1 -
>  8 files changed, 62 insertions(+), 45 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)