netdev - Re: [PATCH net v3 5/6] usbnet: ipheth: refactor NCM datagram loop, fix DPE OoB read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db62a6ad-b96a-403a-9b70-9223dc6a3856@redhat.com>
Date: Thu, 28 Nov 2024 10:10:49 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Foster Snowhill <forst@....gy>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: Georgi Valkov <gvalkov@...il.com>, Simon Horman <horms@...nel.org>,
 Oliver Neukum <oneukum@...e.com>, netdev@...r.kernel.org,
 linux-usb@...r.kernel.org
Subject: Re: [PATCH net v3 5/6] usbnet: ipheth: refactor NCM datagram loop,
 fix DPE OoB read

On 11/24/24 00:54, Foster Snowhill wrote:
> Introduce an rx_error label to reduce repetitions in the header signature
> checks.
> 
> Store wDatagramIndex and wDatagramLength after endianness conversion to
> avoid repeated le16_to_cpu() calls.
> 
> Rewrite the loop to return on a null trailing DPE, which is required
> by the CDC NCM spec. In case it is missing, fall through to rx_error.
> 
> Fix an out-of-bounds DPE read, limit the number of processed DPEs to
> the amount that fits into the fixed-size NDP16 header.

It looks like this patch is doing 2 quite unrelated things, please split
it in 2 separate patch:

patch 1 refactors the code introducing the rx_error label
patch 2 fixes the out-of-bounds

Thanks,

Paolo