netdev - RE: [PATCH iwl-net] ice: fix incorrect PHY settings for 100 GB/s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB490450E38EC6282431DCBE8D942A2@PH0PR11MB4904.namprd11.prod.outlook.com>
Date: Fri, 29 Nov 2024 12:59:25 +0000
From: "Korba, Przemyslaw" <przemyslaw.korba@...el.com>
To: Richard Cochran <richardcochran@...il.com>, Andrew Lunn <andrew@...n.ch>
CC: "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Olech, Milena" <milena.olech@...el.com>,
	Vladimir Oltean <olteanv@...il.com>
Subject: RE: [PATCH iwl-net] ice: fix incorrect PHY settings for 100 GB/s

> On Thu, Nov 28, 2024 at 05:20:44PM +0100, Andrew Lunn wrote:
> 
> > "only Intel's driver" is a bit of a worry. Part of being a Maintainer
> > is to ensure that all drivers behave the same. There should not be any
> > difference between an Intel PTP device, a Marvell PTP devices, a
> > Microchip PTP device etc. They should all implement the API in a
> > uniform way.
> 
> Yes, and I appreciate it being on CC even for driver changes.
> 
> > What i have also seen is that if one driver gets something wrong,
> > other drivers might as well.
> 
> Yeah, unfortunately there are many device drivers (not just PTP/network drivers)
> that get things wrong.  These are then copied by the authors of new drivers, and
> so on.
> 
> Thanks,
> Richard

Sure, thanks! Will keep in mind for the future : )
Thanks, 
Przmek