netdev - Re: [PATCH v2] ethtool: add support for ETHTOOL_A_CABLE_FAULT_LENGTH_SRC and ETHTOOL_A_CABLE_RESULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3774dd61-6074-4cd9-97e0-aab7a275f428@lunn.ch>
Date: Fri, 29 Nov 2024 15:55:25 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Michal Kubecek <mkubecek@...e.cz>, kernel@...gutronix.de,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] ethtool: add support for
 ETHTOOL_A_CABLE_FAULT_LENGTH_SRC and ETHTOOL_A_CABLE_RESULT_SRC

On Fri, Nov 29, 2024 at 07:11:39AM +0100, Oleksij Rempel wrote:
> On Thu, Nov 28, 2024 at 06:41:11PM +0100, Andrew Lunn wrote:
> > > > ETHTOOL_A_CABLE_RESULT_SRC is a new property, so only newer kernels
> > > > will report it. I think you need an
> > > > if (tb[ETHTOOL_A_CABLE_RESULT_SRC]) here, and anywhere else you look for
> > > > this property?
> > > 
> > > Looks like a forgotten edit of copy&pasted text
> > 
> > Duh! Yes, i did forget.
> 
> Arrr... i check existence of wrong field...  (-‸ლ)

We all failed the copy/paste test :-(

	Andrew