netdev - Re: [PATCH bpf-next 3/3] bpf: cpumap: Add gro support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o71ugm7j.fsf@toke.dk>
Date: Mon, 02 Dec 2024 16:04:48 +0100
From: Toke Høiland-Jørgensen <toke@...hat.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Alexei
 Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend
 <john.fastabend@...il.com>, Andrii Nakryiko <andrii@...nel.org>, Martin
 KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, KP
 Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo
 <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>
Cc: Daniel Xu <dxu@...uu.xyz>, aleksander.lobakin@...el.com,
 netdev@...r.kernel.org, bpf@...r.kernel.org, Lorenzo Bianconi
 <lorenzo@...nel.org>
Subject: Re: [PATCH bpf-next 3/3] bpf: cpumap: Add gro support

Lorenzo Bianconi <lorenzo@...nel.org> writes:

> Introduce GRO support to cpumap codebase moving the cpu_map_entry
> kthread to a NAPI-kthread pinned on the selected cpu.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

Pretty neat with such a straight-forward conversion. Just one nit:

[...]

> +	rcu_read_lock();
[...]
> +	rcu_read_unlock();

napi_threaded_poll_loop() already does local_bh_disable/enable() around
the polling function, so these are redundant :)

-Toke