netdev - Re: [PATCH net] net: usb: usbnet: fix name regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241202065600.4d98a3fe@kernel.org>
Date: Mon, 2 Dec 2024 06:56:00 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: 'Dominique MARTINET' <dominique.martinet@...ark-techno.com>
Cc: David Laight <David.Laight@...lab.com>, Oliver Neukum
 <oneukum@...e.com>, "edumazet@...gle.com" <edumazet@...gle.com>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, Greg Thelen <gthelen@...gle.com>, John Sperbeck
 <jsperbeck@...gle.com>, "stable@...r.kernel.org" <stable@...r.kernel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH net] net: usb: usbnet: fix name regression

On Mon, 2 Dec 2024 17:36:51 +0900 'Dominique MARTINET' wrote:
> The new check however no longer cares about the address globality, and
> just basically always renames the interface if the driver provided a
> mac ?

Any way we can identify those devices and not read the address from 
the device? Reading a locally administered address from the device
seems rather pointless, we can generate one ourselves.

> If that is what was intended, I am fine with this, but I think these
> local ppp usb interfaces are rather common in the cheap modem world.

Which will work, as long as they are marked appropriately; that is
marked with FLAG_POINTTOPOINT.