netdev - Re: [PATCH net] ethtool: Fix access to uninitialized fields in set RXNFC command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41d7f809-a75c-6107-3698-796163b5ab3d@gmail.com>
Date: Mon, 2 Dec 2024 17:28:53 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Gal Pressman <gal@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Dragos Tatulea <dtatulea@...dia.com>, Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net] ethtool: Fix access to uninitialized fields in set
 RXNFC command

On 02/12/2024 16:48, Gal Pressman wrote:
> The check for non-zero ring with RSS is only relevant for
> ETHTOOL_SRXCLSRLINS command, in other cases the check tries to access
> memory which was not initialized by the userspace tool. Only perform the
> check in case of ETHTOOL_SRXCLSRLINS.
> 
> Without this patch, filter deletion (for example) could statistically
> result in a false error:
>   # ethtool --config-ntuple eth3 delete 484
>   rmgr: Cannot delete RX class rule: Invalid argument
>   Cannot delete classification rule
> 
> Fixes: 9e43ad7a1ede ("net: ethtool: only allow set_rxnfc with rss + ring_cookie if driver opts in")
> Link: https://lore.kernel.org/netdev/871a9ecf-1e14-40dd-bbd7-e90c92f89d47@nvidia.com/
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Gal Pressman <gal@...dia.com>

Reviewed-by: Edward Cree <ecree.xilinx@...il.com>