netdev - RE: [PATCH] net: dsa: microchip: KSZ9896 register regmap alignment to 32 bit boundaries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <DM3PR11MB87361344332FA27FEFA94FDCEC352@DM3PR11MB8736.namprd11.prod.outlook.com>
Date: Mon, 2 Dec 2024 23:21:51 +0000
From: <Tristram.Ha@...rochip.com>
To: <jesseevg@...il.com>
CC: <andrew@...n.ch>, <olteanv@...il.com>, <jesse.vangavere@...oteq.com>,
	<netdev@...r.kernel.org>, <Woojung.Huh@...rochip.com>,
	<UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH] net: dsa: microchip: KSZ9896 register regmap alignment to
 32 bit boundaries

> Commit (SHA1: 8d7ae22ae9f8c8a4407f8e993df64440bdbd0cee) fixed this issue
> for the KSZ9477 by adjusting the regmap ranges.
> 
> The same issue presents itself on the KSZ9896 regs and is fixed with
> the same regmap range modification.
> 
> Signed-off-by: Jesse Van Gavere <jesse.vangavere@...oteq.com>
> ---
>  drivers/net/dsa/microchip/ksz_common.c | 42 +++++++++++---------------
>  1 file changed, 18 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/net/dsa/microchip/ksz_common.c
> b/drivers/net/dsa/microchip/ksz_common.c
> index 920443ee8ffd..8a03baa6aecc 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -1100,10 +1100,9 @@ static const struct regmap_range ksz9896_valid_regs[] = {
>         regmap_reg_range(0x1030, 0x1030),
>         regmap_reg_range(0x1100, 0x1115),
>         regmap_reg_range(0x111a, 0x111f),
> -       regmap_reg_range(0x1122, 0x1127),
> -       regmap_reg_range(0x112a, 0x112b),
> -       regmap_reg_range(0x1136, 0x1139),
> -       regmap_reg_range(0x113e, 0x113f),
> +       regmap_reg_range(0x1120, 0x112b),
> +       regmap_reg_range(0x1134, 0x113b),
> +       regmap_reg_range(0x113c, 0x113f),
>         regmap_reg_range(0x1400, 0x1401),
>         regmap_reg_range(0x1403, 0x1403),
>         regmap_reg_range(0x1410, 0x1417),
> @@ -1130,10 +1129,9 @@ static const struct regmap_range ksz9896_valid_regs[] = {
>         regmap_reg_range(0x2030, 0x2030),
>         regmap_reg_range(0x2100, 0x2115),
>         regmap_reg_range(0x211a, 0x211f),
> -       regmap_reg_range(0x2122, 0x2127),
> -       regmap_reg_range(0x212a, 0x212b),
> -       regmap_reg_range(0x2136, 0x2139),
> -       regmap_reg_range(0x213e, 0x213f),
> +       regmap_reg_range(0x2120, 0x212b),
> +       regmap_reg_range(0x2134, 0x213b),
> +       regmap_reg_range(0x213c, 0x213f),
>         regmap_reg_range(0x2400, 0x2401),
>         regmap_reg_range(0x2403, 0x2403),
>         regmap_reg_range(0x2410, 0x2417),
> @@ -1160,10 +1158,9 @@ static const struct regmap_range ksz9896_valid_regs[] = {
>         regmap_reg_range(0x3030, 0x3030),
>         regmap_reg_range(0x3100, 0x3115),
>         regmap_reg_range(0x311a, 0x311f),
> -       regmap_reg_range(0x3122, 0x3127),
> -       regmap_reg_range(0x312a, 0x312b),
> -       regmap_reg_range(0x3136, 0x3139),
> -       regmap_reg_range(0x313e, 0x313f),
> +       regmap_reg_range(0x3120, 0x312b),
> +       regmap_reg_range(0x3134, 0x313b),
> +       regmap_reg_range(0x313c, 0x313f),
>         regmap_reg_range(0x3400, 0x3401),
>         regmap_reg_range(0x3403, 0x3403),
>         regmap_reg_range(0x3410, 0x3417),
> @@ -1190,10 +1187,9 @@ static const struct regmap_range ksz9896_valid_regs[] = {
>         regmap_reg_range(0x4030, 0x4030),
>         regmap_reg_range(0x4100, 0x4115),
>         regmap_reg_range(0x411a, 0x411f),
> -       regmap_reg_range(0x4122, 0x4127),
> -       regmap_reg_range(0x412a, 0x412b),
> -       regmap_reg_range(0x4136, 0x4139),
> -       regmap_reg_range(0x413e, 0x413f),
> +       regmap_reg_range(0x4120, 0x412b),
> +       regmap_reg_range(0x4134, 0x413b),
> +       regmap_reg_range(0x413c, 0x413f),
>         regmap_reg_range(0x4400, 0x4401),
>         regmap_reg_range(0x4403, 0x4403),
>         regmap_reg_range(0x4410, 0x4417),
> @@ -1220,10 +1216,9 @@ static const struct regmap_range ksz9896_valid_regs[] = {
>         regmap_reg_range(0x5030, 0x5030),
>         regmap_reg_range(0x5100, 0x5115),
>         regmap_reg_range(0x511a, 0x511f),
> -       regmap_reg_range(0x5122, 0x5127),
> -       regmap_reg_range(0x512a, 0x512b),
> -       regmap_reg_range(0x5136, 0x5139),
> -       regmap_reg_range(0x513e, 0x513f),
> +       regmap_reg_range(0x5120, 0x512b),
> +       regmap_reg_range(0x5134, 0x513b),
> +       regmap_reg_range(0x513c, 0x513f),
>         regmap_reg_range(0x5400, 0x5401),
>         regmap_reg_range(0x5403, 0x5403),
>         regmap_reg_range(0x5410, 0x5417),
> @@ -1250,10 +1245,9 @@ static const struct regmap_range ksz9896_valid_regs[] = {
>         regmap_reg_range(0x6030, 0x6030),
>         regmap_reg_range(0x6100, 0x6115),
>         regmap_reg_range(0x611a, 0x611f),
> -       regmap_reg_range(0x6122, 0x6127),
> -       regmap_reg_range(0x612a, 0x612b),
> -       regmap_reg_range(0x6136, 0x6139),
> -       regmap_reg_range(0x613e, 0x613f),
> +       regmap_reg_range(0x6120, 0x612b),
> +       regmap_reg_range(0x6134, 0x613b),
> +       regmap_reg_range(0x613c, 0x613f),
>         regmap_reg_range(0x6300, 0x6301),
>         regmap_reg_range(0x6400, 0x6401),
>         regmap_reg_range(0x6403, 0x6403),

The port address range 0x#100-0x#13F just maps to the PHY registers 0-31,
so it can be simply one single regmap_reg_range(0x1100, 0x113f) instead
of many.  I suggest using regmap_reg_range(0x1100, 0x111f) and
regmap_reg_range(0x1120, 0x113f) to remind people the high range address
needs special handling.

I also do not know why those _register_set are not enforced across all
KSZ9897 related switches.